icrc index getLedgerId #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already do something like that in Oisy. Let me check. |
size-limit report 📦
|
|
Indeed @mstrasinskis, a function See here https://github.com/dfinity/ic-js/tree/main/packages/ledger-icrc#gear-ledgerid |
…edger-id # Conflicts: # packages/ledger-icrc/src/index.canister.ts
|
Looks like this PR adds it on the non-ng index canister which does not seem to have it yet. |
|
@peterpeterparker, thank you for pointing this out. However, as @dskloetd already mentioned, this PR exposes the API on the non-NG canister, which is used in nns-dapp. |
|
Sounds good. Can you use the same naming |
Good idea, this way it will be easier to switch to the NG canister later. |
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Aug 12, 2024
# Motivation To make [getLedgerId api](dfinity/ic-js#693) available in `nns-dapp` the `ic-js` package needs to be upgraded. # Changes - `npm run upgrade:next`. - Add `[]` to some new optional fields in `convertSwapInitParams` to fix type checking errors. # Tests - Pass # Todos - [ ] Add entry to changelog (if necessary). Not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the import token functionality, we need to ensure that the provided by users index canister is correctly associated with the same token and not mistakenly linked to a different ledger canister. To achieve this, we going to use the
ledger_idAPI of the index canister, which returns the corresponding ledger canister ID. This PR introduces a function that makes theledger_idrequest.Changes
Tests
Todos
Not necessary.