Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IC and add conversions for new NNS Governance types #686

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Update IC and add conversions for new NNS Governance types #686

merged 3 commits into from
Jul 30, 2024

Conversation

jasonz-dfinity
Copy link
Contributor

@jasonz-dfinity jasonz-dfinity commented Jul 26, 2024 •
edited
Loading

Motivation

New types in NNS Governance are added which includes new variants which will fail the automatic update. Add converters for request/response involving those variants

Changes

  1. Ran scripts/import-candid ../../ic and scripts/compile-idl-js.
  2. Get rid of everything other than nns changes: packages/{ckbtc,cketh,cmc,ledger-icp,ledger-icrc,sns,ic-management}
  3. Added conversion for UpdateCanisterSettings, StopOrStartCansiter, SetVisibility and Neuron::visibility

Tests

Unit tests

Todos

  • [ x] Add entry to changelog (if necessary).

@jasonz-dfinity jasonz-dfinity requested review from a team as code owners July 26, 2024 22:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.9 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 36.36 KB (+1.89% 🔺)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.71 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.78 KB (0%)

@jasonz-dfinity jasonz-dfinity marked this pull request as draft July 26, 2024 22:50
@jasonz-dfinity jasonz-dfinity force-pushed the jason/governance-proposal-types branch from 73ad629 to a3f9ef2 Compare July 27, 2024 00:01
@jasonz-dfinity jasonz-dfinity marked this pull request as ready for review July 27, 2024 00:02
@jasonz-dfinity jasonz-dfinity force-pushed the jason/governance-proposal-types branch from d98d0b4 to 3911bff Compare July 27, 2024 00:03
@jasonz-dfinity jasonz-dfinity force-pushed the jason/governance-proposal-types branch from 83b92f8 to 4384a40 Compare July 27, 2024 00:05
mstrasinskis
mstrasinskis approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jasonz-dfinity jasonz-dfinity enabled auto-merge (squash) July 30, 2024 15:02
@jasonz-dfinity jasonz-dfinity merged commit 3eae8f7 into main Jul 30, 2024
11 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/governance-proposal-types branch July 30, 2024 15:28
@dskloetd dskloetd mentioned this pull request Aug 12, 2024
Merged
1 task
dskloetd added a commit that referenced this pull request Aug 12, 2024
@dskloetd
Fix changelog (#694)
e980532 
# Motivation

I just discovered that #681 and
#686 added changelog entries to an
existing release, instead of the "Next" release.

# Changes

Move the changelog entry to the "Next" release.

# Tests

no

# Todos

- [x] Add entry to changelog (if necessary).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonz-dfinity @mstrasinskis