Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update cketh candid files #683

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: update cketh candid files #683

merged 1 commit into from
Jul 22, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

This PR update the ckETH candid files as provided in bot PR #682 and add the new additional candid optional fields to the orchestrator info mock.

Changes

Todos

  • Add entry to changelog (if necessary).

@peterpeterparker
feat: update cketh candid files
c260b55 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker peterpeterparker requested review from a team as code owners July 22, 2024 11:50
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.45 KB (-3.02% 🔽)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.9 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 35.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.71 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.78 KB (0%)

dskloetd
dskloetd approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 80e1f5d into main Jul 22, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/update-cketh-candid branch July 22, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @dskloetd