Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nns governance candid 2023 12 06 #497

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Upgrade nns governance candid 2023 12 06 #497

merged 11 commits into from
Dec 7, 2023

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Dec 7, 2023 •
edited
Loading

Motivation

Upgrade nns/governance and nns/governance-test to latest ic version.

Changes

  • ./scripts/import-candid
  • ./scripts/compile-idl-js
  • update response converters
  • nns size limit increased 35 -> 40KB

Tests

  • works

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.98 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.93 KB (0%)
@dfinity/ledger-icp 14.95 KB (0%)
@dfinity/nns 34.58 KB (+1.48% 🔺)
@dfinity/nns-proto 76.42 KB (0%)
@dfinity/sns 15.15 KB (0%)
@dfinity/utils 4.37 KB (0%)
@dfinity/ic-management 1.93 KB (0%)

lmuntaner
lmuntaner reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there still some TODO to be cleaned up before merging?

packages/nns/src/enums/governance.enums.ts Show resolved Hide resolved
packages/nns/src/canisters/governance/response.converters.ts Outdated Show resolved Hide resolved
packages/nns/src/canisters/governance/response.converters.ts Outdated Show resolved Hide resolved
packages/nns/src/canisters/governance/response.converters.ts Outdated Show resolved Hide resolved
@mstrasinskis mstrasinskis marked this pull request as draft December 7, 2023 12:15
mstrasinskis and others added 3 commits December 7, 2023 13:23
@mstrasinskis
Revert "chore: linter"
e088c74 
This reverts commit 6b624b6.

# Conflicts:
#	packages/nns/src/types/governance_converters.ts
@mstrasinskis
comments
7957f5c
@mstrasinskis
Merge branch 'main' into upgrade-nns-governance-candid-2023-12-06
7816446
@mstrasinskis mstrasinskis marked this pull request as ready for review December 7, 2023 12:28
lmuntaner
lmuntaner approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@mstrasinskis mstrasinskis merged commit e314c91 into main Dec 7, 2023
11 checks passed
@mstrasinskis mstrasinskis deleted the upgrade-nns-governance-candid-2023-12-06 branch December 7, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstrasinskis @lmuntaner @cgundy