Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose SnsPercentage #489

Merged
merged 2 commits into from
Nov 29, 2023
Merged

expose SnsPercentage #489

merged 2 commits into from
Nov 29, 2023

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Expose SnsPercentage to be used in nns-dapp

Changes

  • add export
  • npm run format

Tests

Works

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.88 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.85 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 15.04 KB (0%)
@dfinity/utils 4.14 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@mstrasinskis mstrasinskis merged commit de396fa into main Nov 29, 2023
12 checks passed
@mstrasinskis mstrasinskis deleted the expose_sns_percentage_type branch November 29, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @lmuntaner