Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sns governance candids #482

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Upgrade sns governance candids #482

merged 2 commits into from
Nov 23, 2023

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Upgrade sns governance canister types

Changes

  • import-candid & compile-idl-js

Tests

Still works.

Todos

  • Add entry to changelog (if necessary).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.88 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.83 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 15.04 KB (+0.78% 🔺)
@dfinity/utils 4.12 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@mstrasinskis mstrasinskis marked this pull request as ready for review November 23, 2023 14:54
lmuntaner
lmuntaner approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mstrasinskis mstrasinskis merged commit 6bf9c68 into main Nov 23, 2023
12 checks passed
@mstrasinskis mstrasinskis deleted the upgrade-sns-governance-candid branch November 23, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @lmuntaner