Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpdateElectedHostosVersions and UpdateNodesHostosVersion proposals #413

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Extend NnsFunction enum with UpdateElectedHostosVersions and UpdateNodesHostosVersion.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.79 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.17 KB (0%)
@dfinity/nns 33.77 KB (+0.08% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.91 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait until they are supported in nns dapp to merge, right?

github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Oct 16, 2023
# Motivation

Adds support for `UpdateElectedHostosVersions` and
`UpdateNodesHostosVersion` payloads.

- [ ] ic-js changes dfinity/ic-js#413

# Changes

- proposal labels/descriptions (from the dashboard)

# Tests

Works

# Todos

- [ ] Add entry to changelog (if necessary).
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Oct 20, 2023
# Motivation

Adds support for `UpdateElectedHostosVersions` and
`UpdateNodesHostosVersion` payloads.

- [ ] ic-js changes dfinity/ic-js#413

# Changes

- proposal labels/descriptions (from the dashboard)

# Tests

Works

# Todos

- [ ] Add entry to changelog (if necessary).
@mstrasinskis
Copy link
Contributor Author

We should wait until they are supported in nns dapp to merge, right?

Just tested against the testnet.

@mstrasinskis mstrasinskis merged commit 014e017 into main Oct 23, 2023
10 checks passed
@mstrasinskis mstrasinskis deleted the add-proposal-40-and-41-support branch October 23, 2023 09:12
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Oct 23, 2023
# Motivation

Adds support for `UpdateElectedHostosVersions` and
`UpdateNodesHostosVersion` payloads.

- [x] ic-js changes dfinity/ic-js#413

# Changes

- proposal labels/descriptions (from the dashboard)

# Tests

Works

# Todos

- [ ] Add entry to changelog (if necessary).
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Oct 23, 2023
# Motivation

Upgrade `ic-js` version to make new proposals
([40&41](dfinity/ic-js#413)) available.

# Changes

- `npm run upgrade:next`

# Tests

Proposals tested manually against the testnet.

# Todos

- [ ] Add entry to changelog (if necessary).
Not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants