Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1-proposal-related-candid-update #391

Merged
merged 2 commits into from
Aug 4, 2023
Merged

1-proposal-related-candid-update #391

merged 2 commits into from
Aug 4, 2023

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Aug 4, 2023 •
edited
Loading

Motivation

Rename a field in 1-proposal types.

Changes

  • neuronsFundInvestment -> neuronsFundInvestmentIcp

Tests

Locally after creation an sns proposal
localhost_5173_proposal__u=qsgjb-riaaa-aaaaa-aaaga-cai proposal=4 (2)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 7.84 KB (0%)
@dfinity/cmc 998 B (0%)
@dfinity/ledger 2.51 KB (0%)
@dfinity/nns 30.8 KB (+0.03% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 13.39 KB (0%)
@dfinity/utils 3.74 KB (0%)
@dfinity/rosetta-client -19 B (0%)
@dfinity/ic-management 2.04 KB (0%)

lmuntaner
lmuntaner approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstrasinskis mstrasinskis merged commit cd62540 into main Aug 4, 2023
9 checks passed
@mstrasinskis mstrasinskis deleted the 1-proposal-related-candid-update branch August 4, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @lmuntaner