Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIX-1381: Add total tokens supply endpoint #304

Merged
merged 2 commits into from
Mar 8, 2023
Merged

GIX-1381: Add total tokens supply endpoint #304

merged 2 commits into from
Mar 8, 2023

Conversation

lmuntaner
Copy link
Contributor

Motivation

Show important data like total tokens supply in the Project Detail page in the nns dapp.

Therefore, we expose the ledger endpoint icrc1_total_supply to use it in nns dapp and others to get this important data.

Changes

  • Add new endpoint totalTokensSupply to IcrcLedgerCanister.
  • Add new endpoint totalTokensSupply to Sns Wrapper.

Tests

  • Test new endpoint in IcrcLedgerCanister
  • Test new endpoint in SNS Wrapper

@lmuntaner
Copy link
Contributor Author

@peterpeterparker please review

peterpeterparker
peterpeterparker approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

packages/ledger/src/ledger.canister.ts Show resolved Hide resolved
@lmuntaner lmuntaner merged commit 5866c44 into main Mar 8, 2023
@lmuntaner lmuntaner deleted the GIX-1381_LM_add-total-tokens-supply branch March 8, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @peterpeterparker