Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build utils and ledger before other packages #303

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Build utils and ledger before other packages #303

merged 3 commits into from
Mar 7, 2023

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Mar 6, 2023

Motivation

npm ci && npm run test on a clean branch gives errors because of dependencies between the packages.

Changes

  1. Add a line in HACKING.md about building utils and ledger first.
  2. Add npm run test-all script which builds packages in the correct order before running all the tests.

Tests

rm -rf packages/*/dist node_modules/ && npm run test-all

peterpeterparker
peterpeterparker approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@dskloetd dskloetd merged commit 86d0faf into main Mar 7, 2023
@dskloetd dskloetd deleted the kloet/test-all branch March 7, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @peterpeterparker