Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ckBTC update balance #289

Merged
merged 10 commits into from
Feb 13, 2023
Merged

feat: ckBTC update balance #289

merged 10 commits into from
Feb 13, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

Provide a function to cal update_balance of the ckBTC minter.

Changes

  • implement updateBalance
  • add references in the README to link easily with the IC source code

Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterpeterparker peterpeterparker merged commit d775fc0 into main Feb 13, 2023
@peterpeterparker peterpeterparker deleted the feat/ckbtc-update-balance branch February 13, 2023 10:33
peterpeterparker added a commit to dfinity/nns-dapp that referenced this pull request Feb 14, 2023
# Motivation

Call `minter.update_balance` to finalize transferring bitcoin to ckBTC.

# PR

- [x] dfinity/ic-js#289
- [x] dfinity/ic-js#290

# Changes

- call `update_balance` and reload account on success in ckBTC "Receive" modal
- integrate related API and services from ic-js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants