GIX-1284: New Sale lifecycle and proposal param #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mstrasinskis please review |
lmuntaner
force-pushed
the
GIX-1284_LM_new-sale-lifecycle-state
branch
from
c504c4d
to
e38116b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support new SNS Sale Lifecycle state: Adopted.
Changes
Most of the changes are candid related.
A part from those ones, the review should focus on:
getLifecyclein sns swap canister.getLifecyclein sns wrapper canister, that redirects to the sns swap canister method.sale_delay_secondsin converters.Tests