feat: ckbtc-js #281
Merged
feat: ckbtc-js #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lmuntaner
approved these changes
Feb 7, 2023
|
@lmuntaner did not had the time yet, let me provide a md file in another pr now |
peterpeterparker
added a commit
to dfinity/nns-dapp
that referenced
this pull request
Feb 8, 2023
# Motivation Init ckBTC "Receive" modal. # PRs - [x] dfinity/ic-js#281 # Changes - uses `@dfinity/ckbtc` - init new feature "ckBTC receive" (effective modal UI will be implemented in next PRs) - implement get BTC address - new feature flag `ENABLE_CKBTC_RECEIVE` - rename `isStringNonNullishNotEmpty` to `notEmptyString` as discussed with @mstrasinskis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create a ckBTC-js new library and implement first feature
get_btc_address.To get started it will only interface minter canister related features.
Changes
@dfinity/ckbtcget_btc_addressNote
Not related to the PR but noticed
"directory": "packages/ledger"information was incorrectly set inpackage.jsonof ledger so fixed it.