Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: sns neuron management interfaces #230

Merged
merged 3 commits into from
Nov 4, 2022
Merged

refact: sns neuron management interfaces #230

merged 3 commits into from
Nov 4, 2022

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Refactor interfaces and sns neuron management param converters to improve types and spare some bytes in built js.

Changes

  • helper functions in sns governance converters
    • toManageNeuronCommand(...)
    • toManageNeuronConfigureCommand(...)
  • SnsNeuronManagementParams interface to consolidate neuron management param converters

Tests

  • no changes

lmuntaner
lmuntaner approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peterpeterparker
peterpeterparker approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mstrasinskis mstrasinskis enabled auto-merge (squash) November 4, 2022 13:25
@mstrasinskis mstrasinskis merged commit 038c730 into main Nov 4, 2022
@mstrasinskis mstrasinskis deleted the GIX-1117_refactor_sns_request_interfaces branch November 4, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstrasinskis @lmuntaner @peterpeterparker