[Node-1833] Add optional DNSSEC validation support#77
Merged
shilingwang merged 4 commits intomainfrom Jan 27, 2026
Merged
Conversation
shilingwang
changed the title
shilingwang
force-pushed
the
shiling/dnssec-option
branch
from
bfba483 to
3e97ccd
Compare
Add a configurable option to disable DNSSEC validation for DNS queries in ic-bn-lib-common types. DNSSEC validation is enabled by default. Changes: - Add dnssec_disabled field to DNS Options struct (defaults to false) - Add --dns-dnssec-disabled CLI flag and DNS_DNSSEC_DISABLED env var - Add field to DnsCli struct and From<&DnsCli> conversion - DNSSEC is enabled by default, users can opt-out via the flag This prepares the types for DNSSEC support. The actual usage in the resolver will be added in a follow-up PR after this is published.
shilingwang
force-pushed
the
shiling/dnssec-option
branch
from
3e97ccd to
cc00968
Compare
blind-oracle
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnssec-ringfeature was already compiled in dependencies but not being utilizeddnssec_disabledfield to DNSOptionsstruct (defaults tofalse)Motivation
While the
dnssec-ringfeature is enabled inhickory-resolverdependencies, DNSSEC validation was explicitly disabled by hardcodingpreserve_intermediates = false. This change makes DNSSEC validation an opt-out feature (with follow-up change on the preserve_intermediate = true) that users can enable when needed, while maintaining backward compatibility by keeping it disabled by default.Changes
dnssec_disabled: boolfield toOptionsstruct inic-bn-lib-common/src/types/dns.rsTest Plan