Skip to content

add: Deploy to ICP Ninja + standardize README #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025

Conversation

jessiemongeon1
Copy link
Contributor

Overview
Why do we need this feature? What are we trying to accomplish?

Requirements
What requirements are necessary to consider this problem solved?

Considered Solutions
What solutions were considered?

Recommended Solution
What solution are you recommending? Why?

Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?

@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner June 18, 2025 20:45
Copy link
Member

@oggy-dfin oggy-dfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments before merging

jessiemongeon1 and others added 2 commits June 20, 2025 09:19
Co-authored-by: oggy-dfin <89794951+oggy-dfin@users.noreply.github.com>
@jessiemongeon1 jessiemongeon1 merged commit 1a69da7 into master Jun 20, 2025
12 checks passed
@jessiemongeon1 jessiemongeon1 deleted the jessiemongeon1-patch-38 branch June 20, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants