-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add watchdog stop-switch for bitcoin canister #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test to check whether the config can be changed properly? Probably we need an end-to-end test for that?
I'd prefer to separate such an end-to-end test from this PR because it might be a bit too complicated, because to make it truly end-to-end it'd need to intercept HTTP requests from the canister and provide mock responses. |
LGTMs? |
This change adds reading and writing bitcoin canister API access config flag.
API access target is calculated based on the height health status, actual value is read from the bitcoin canister. If there is a difference between the target and actual values, then watchdog tries to rewrite the bitcoin canister API access config flag.
This change also exposes additional metrics: