Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: watchdog canister running out of cycles when sending http_request #195

Merged
merged 4 commits into from
Apr 26, 2023
Merged

fix: watchdog canister running out of cycles when sending http_request #195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
389129d
fix http_request with no cycles
maksymar Apr 26, 2023
f5114fb
add http_request_with_cycles into ic_http
maksymar Apr 26, 2023
10ab192
comment
maksymar Apr 26, 2023
02730f1
comment
maksymar Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ic-http/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ edition = "2021"

[dependencies]
candid = "0.8.2"
ic-cdk = "0.6.0"
ic-cdk-macros = "0.6.0"
ic-cdk = "0.7.4"
ic-cdk-macros = "0.6.10"

# Added to use non-blocking sleep to mock delayed responses.
# Currently wasm32 does not support tokio, so we need to disable it for wasm32.
Expand Down
4 changes: 2 additions & 2 deletions ic-http/example_canister/src/canister_backend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ path = "src/main.rs"

[dependencies]
candid = "0.8.2"
ic-cdk = "0.6.0"
ic-cdk-macros = "0.6.0"
ic-cdk = "0.7.4"
ic-cdk-macros = "0.6.10"
ic-http = {path = "../../../"}
serde = { version = "1.0.158", features = [ "derive" ] }
serde_json = "1.0.94"
Expand Down
2 changes: 1 addition & 1 deletion ic-http/src/http_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ pub async fn http_request(arg: CanisterHttpRequestArgument) -> CallResult<(HttpR
/// Make an HTTP request to a given URL and return the HTTP response, possibly after a transformation.
#[cfg(target_arch = "wasm32")]
pub async fn http_request(arg: CanisterHttpRequestArgument) -> CallResult<(HttpResponse,)> {
ic_cdk::api::management_canister::http_request::http_request(arg).await
ic_cdk::api::management_canister::http_request::http_request_with_cycles(arg, 0).await
maksymar marked this conversation as resolved.
Show resolved Hide resolved
}
4 changes: 2 additions & 2 deletions watchdog/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ path = "src/main.rs"

[dependencies]
candid = "0.8.2"
ic-cdk = "0.6.0"
ic-cdk-macros = "0.6.0"
ic-cdk = "0.7.4"
ic-cdk-macros = "0.6.10"
ic-cdk-timers = "0.1"
serde = { version = "1.0.158", features = [ "derive" ] }
serde_json = "1.0.94"
Expand Down