Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v1 agent compatibility with v2 actor tests #902

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

krpeacock
Copy link
Contributor

Description

Due to some changes in the return types of the HttpAgent call response, this test ensures backwards compatibility with v1 agents is preserved

How Has This Been Tested?

New integration test suite added in e2e tests

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner July 12, 2024 18:45
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 85.99 KB (-0.01% 🔽)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.84 KB (0%)
@dfinity/assets 80.65 KB (+0.01% 🔺)
@dfinity/identity 58.03 KB (0%)
@dfinity/identity-secp256k1 266.58 KB (0%)

@krpeacock krpeacock enabled auto-merge (squash) July 12, 2024 18:54
@krpeacock krpeacock merged commit eaedc19 into main Jul 12, 2024
16 checks passed
@krpeacock krpeacock deleted the kai/v1-agent-compatibility branch July 12, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants