Skip to content

fix: use .ts extension for imports #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nathanosdev
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Copy link
Contributor

github-actions bot commented Jul 15, 2025

size-limit report 📦

Path Size
@dfinity/agent 47.45 KB (0%)
@dfinity/assets 52.51 KB (0%)
@dfinity/auth-client 23.08 KB (0%)
@dfinity/candid 12.96 KB (0%)
@icp-sdk/core 91 B (0%)
@dfinity/identity 22.36 KB (0%)
@dfinity/identity-secp256k1 36.95 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 58.47 KB (0%)

@nathanosdev nathanosdev force-pushed the nathan/use-js-extension branch from be5af60 to c6af46f Compare July 15, 2025 13:39
@nathanosdev nathanosdev changed the title fix: use .js extension for imports fix: use .ts extension for imports Jul 15, 2025
@nathanosdev nathanosdev force-pushed the nathan/use-js-extension branch from c6af46f to f16a8a4 Compare July 15, 2025 13:47
@nathanosdev nathanosdev marked this pull request as ready for review July 15, 2025 15:32
@nathanosdev nathanosdev requested a review from a team as a code owner July 15, 2025 15:32
Copy link
Member

@ilbertt ilbertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the ESLint rule to enforce .ts extension in the local imports, and I think we are good to go

@nathanosdev nathanosdev force-pushed the nathan/use-js-extension branch from 96fbdb6 to dbbaf2c Compare July 16, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants