Fix incomplete data from xdebug#20
Merged
Merged
Conversation
added 2 commits
August 6, 2018 15:45
Owner
|
Go is too fast ;) thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XDebug sometimes sends large data to the debugproxy.
When the debugproxy tries to read that data from the
net.TCPConnnot all data is available sometimes, which causes errors by later processing.Because all message from XDebug are prepended by their body length, I check for each incoming message to fit the expected length.
After implementing the fix I couldn't cause this situation to happen. Maybe because the computation from fix takes a few (nano) seconds so the data is available on the socket (
net.TCPConn).