Skip to content

Run tests in CI on Xcode 15 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Run tests in CI on Xcode 15 #20

merged 1 commit into from
Sep 26, 2023

Conversation

dfed
Copy link
Owner

@dfed dfed commented Sep 25, 2023

As title – gets us testing on Xcode 15 in addition to Xcode 14 in CI

@dfed dfed force-pushed the dfed--xcode-15-ci branch 2 times, most recently from 2d43e21 to b52d72a Compare September 25, 2023 19:33
@dfed dfed changed the base branch from main to dfed--xcode-15-warnings September 25, 2023 19:35
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #20 (1488ef8) into main (446e6c1) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          936       936           
=========================================
  Hits           936       936           
Files Coverage Δ
Tests/AsyncQueueTests/SemaphoreTests.swift 100.00% <100.00%> (ø)

@dfed dfed requested review from bachand and Gabardone September 25, 2023 19:46
@dfed dfed marked this pull request as ready for review September 25, 2023 19:46
Copy link
Collaborator

@Gabardone Gabardone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Base automatically changed from dfed--xcode-15-warnings to main September 26, 2023 00:40
@dfed dfed force-pushed the dfed--xcode-15-ci branch from b52d72a to 1488ef8 Compare September 26, 2023 00:41
@dfed
Copy link
Owner Author

dfed commented Sep 26, 2023

rebased main to delete the now-conflicting commits. Merging on green!

@dfed dfed enabled auto-merge (squash) September 26, 2023 00:41
@dfed dfed merged commit cd8dd84 into main Sep 26, 2023
@dfed dfed deleted the dfed--xcode-15-ci branch September 26, 2023 00:53
Copy link
Collaborator

@bachand bachand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants