-
Notifications
You must be signed in to change notification settings - Fork 1
Data dictionary/key stage 4 #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2836b0f to
e11d440
Compare
cjrace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to start thinking about automated tests on the data dictionary to spot repeated rows and check for special symbols we want to avoid like '&', which we should swap for 'and' etc?
Left a few comments on rows that look like we probably should be standardising
…r script to manual scripts folder
cjrace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmbielby!
Brief overview of changes
Adding Key Stage 4 elements to the data dictionary as agreed with the Key Stage 4 team.
This also adds some broader elements (i.e. used by KS4, but that will also be widely used across other publications).
This includes some elements on SEN, ethnicity etc and uses the breakdown_topic / breakdown combo in places.
Detailed description of changes
As well as adding in the new breakdowns, I've got some updates to the data checker code and some tests added on for validating the data dictionary.
Additional information for reviewers
Issue ticket number/s and link