Skip to content

Conversation

@rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Oct 7, 2025

Brief overview of changes

Adding Key Stage 4 elements to the data dictionary as agreed with the Key Stage 4 team.

This also adds some broader elements (i.e. used by KS4, but that will also be widely used across other publications).

This includes some elements on SEN, ethnicity etc and uses the breakdown_topic / breakdown combo in places.

Detailed description of changes

As well as adding in the new breakdowns, I've got some updates to the data checker code and some tests added on for validating the data dictionary.

Additional information for reviewers

Issue ticket number/s and link

@rmbielby rmbielby self-assigned this Oct 7, 2025
@rmbielby rmbielby added the data-update Updates to the standardised reference data label Oct 7, 2025
@rmbielby rmbielby marked this pull request as draft October 7, 2025 08:29
@rmbielby rmbielby marked this pull request as ready for review October 15, 2025 16:22
@rmbielby rmbielby requested a review from cjrace October 15, 2025 16:25
@rmbielby rmbielby force-pushed the data-dictionary/key-stage-4 branch from 2836b0f to e11d440 Compare October 15, 2025 16:26
Copy link
Collaborator

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to start thinking about automated tests on the data dictionary to spot repeated rows and check for special symbols we want to avoid like '&', which we should swap for 'and' etc?

Left a few comments on rows that look like we probably should be standardising

Copy link
Collaborator

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmbielby!

@rmbielby rmbielby merged commit 2d0d6eb into main Jan 9, 2026
7 checks passed
@rmbielby rmbielby deleted the data-dictionary/key-stage-4 branch January 9, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-standards data-update Updates to the standardised reference data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants