Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire deprecated whitelist option for kiam v4 #204

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Retire deprecated whitelist option for kiam v4 #204

merged 5 commits into from
Apr 27, 2021

Conversation

avnes
Copy link
Contributor

@avnes avnes commented Apr 23, 2021

NOT TO BE MERGED UNTIL next week.

@avnes avnes requested review from abstrask, wcarlsen and a user April 23, 2021 12:43
abstrask
abstrask suggested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@abstrask abstrask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, we only support chart_version 6.0.0 and above.

Maybe we should configure validation for this variable in `vars.tf``, to avoid the problem noted in the EKS manifest for our cluster:

5.10.0 includes uswitch/kiam#427, but image does not - breaks WhitelistRouteRegexp/AllowRouteRegexp

wcarlsen
wcarlsen previously approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@wcarlsen wcarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice with the validate part.

@avnes
Copy link
Contributor Author

avnes commented Apr 26, 2021 •
edited
Loading

With this change, we only support chart_version 6.0.0 and above.

Maybe we should configure validation for this variable in `vars.tf``, to avoid the problem noted in the EKS manifest for our cluster:

5.10.0 includes uswitch/kiam#427, but image does not - breaks WhitelistRouteRegexp/AllowRouteRegexp

That is a good suggestion, so I have implemented that now. I also tested if it worked by reverting to the old version (5.9.0), and the validation kicked in:

Screenshot 2021-04-26 at 09 33 28

wcarlsen
wcarlsen suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@wcarlsen wcarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate logic only works with single digit

abstrask
abstrask suggested changes Apr 26, 2021
View reviewed changes
_sub/compute/k8s-kiam/vars.tf Outdated Show resolved Hide resolved
@SEQUOIIA
Copy link
Member

@wcarlsen

wcarlsen
wcarlsen approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@wcarlsen wcarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wcarlsen
wcarlsen approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@wcarlsen wcarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@avnes
Copy link
Contributor Author

avnes commented Apr 27, 2021

@raras-dfds - could you also please take a second look?

@wcarlsen wcarlsen requested a review from abstrask April 27, 2021 08:08
@avnes avnes merged commit bab9bef into master Apr 27, 2021
@avnes avnes deleted the feature/cloudplatform-225 branch June 18, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcarlsen wcarlsen wcarlsen approved these changes

@abstrask abstrask abstrask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avnes @SEQUOIIA @abstrask @wcarlsen