Skip to content

Conversation

@HashimTheArab
Copy link
Contributor

This PR moves the logic to build the AvailableCommands package out of session and into a public method in the cmd package.

This allows external callers to reuse this method instead of having to duplicate all of the code

@Sandertv
Copy link
Member

Would it not make more sense to make this a public function in the session package? Since it's so directly tied to the protocol?
I would not be so ready to put this in the cmd package since it is quite susceptible to protocol changes.

@HashimTheArab
Copy link
Contributor Author

Fair enough

@HashimTheArab
Copy link
Contributor Author

Changes applied

@HashimTheArab HashimTheArab changed the title Move AvailableCommands build logic out of session, into cmd export method to build AvailableCommands packet for reuse Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants