Implement candles and candle cakes #1147
Conversation
Sandertv
left a comment
Sandertv
left a comment
There was a problem hiding this comment.
Got a couple of ideas for this PR, but the idea with the OptionalColour is exactly what I had in mind. Did you run into any problems doing it this way?
|
All requested changes have been made. |
Sandertv
left a comment
Sandertv
left a comment
There was a problem hiding this comment.
Got a couple of final comments from my end, mostly style stuff, looks good to me otherwise!
| // BreakInfo ... | ||
| func (c Cake) BreakInfo() BreakInfo { | ||
| if c.Candle { | ||
| return newBreakInfo(0.5, alwaysHarvestable, nothingEffective, silkTouchOnlyDrop(Candle{Colour: c.CandleColour})) |
There was a problem hiding this comment.
| return newBreakInfo(0.5, alwaysHarvestable, nothingEffective, silkTouchOnlyDrop(Candle{Colour: c.CandleColour})) | |
| return newBreakInfo(0.5, alwaysHarvestable, nothingEffective, oneOf(Candle{Colour: c.CandleColour})) |
There was a problem hiding this comment.
Missing water log extinguish behavior
|
|
||
| // Colour is the colour of the candle. | ||
| Colour item.OptionalColour | ||
| // Candles is the number of candles. |
There was a problem hiding this comment.
This doesn't seem entirely accurate since Candle{Candles: 0} actually has one candle? Perhaps AdditionalCandles?
| return placed(ctx) | ||
| } | ||
|
|
||
| if added := addCandle(pos.Side(cube.FaceUp)); added && face == cube.FaceUp { |
| return false | ||
| } | ||
|
|
||
| place(tx, pos, c, user, ctx) |
There was a problem hiding this comment.
Should check if there is not air under the position first, i.e. when placing against a wall
3 participants
This PR implements candles and candle cakes.