add ability to enchant item with incompatible enchantments

[FDUTCH]

I think it is better to have this ability

[TwistedAsylumMC]

I think it is better to have this ability
Do you have an actual use case for this feature? Could you give an example?

[FDUTCH]

I think it is better to have this ability
Do you have an actual use case for this feature? Could you give an example?

I'm not going to argue, I know it's pretty pointless, but I just need it

[Dasciam]

we do not have any need to restrict the developer from making items with incompatible enchantments anyway

[TwistedAsylumMC]

I think that's fair enough, but I do feel like this method deserves a better name. Currently it sounds like every enchantment you provided has to be incompatible. What do you think of something like WithIncompatibleEnchantmentsAllowed() or something similar?

[FDUTCH]

I think that's fair enough, but I do feel like this method deserves a better name. Currently it sounds like every enchantment you provided has to be incompatible. What do you think of something like WithIncompatibleEnchantmentsAllowed() or something similar?

maybe, I'm not too good at naming

[Flonja]

or have the WithEnchantments method be WithEnchantments(ignoreIncompatibles bool, enchantments Enchantment...). You would break the original usage for little gain tho...

[FDUTCH]

or have the WithEnchantments method be WithEnchantments(ignoreIncompatibles bool, enchantments Enchantment...). You would break the original usage for little gain tho...

I think it's better to create a separate method for this

[FDUTCH]

I guess it is ready to be merged

[FDUTCH]

maybe merge? 🤔