improve commandline processing #1091
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
✂️ |
# Conflicts: # server/player/player.go
Contributor
Author
|
I think I've achieved everything I need from this PR 🔥 |
DaPigGuy
reviewed
Dec 16, 2025
| // string ... | ||
| func (p parser) string(line *Line, v reflect.Value) error { | ||
| if p.fields == 1 { | ||
| return p.restAsString(line, v) |
Member
There was a problem hiding this comment.
Isn't this what the Varargs parameter type is for?
Comment on lines
+50
to
+55
| val := v[0] | ||
| if val == "" { | ||
| line.RemoveNext() | ||
| return line.Next() | ||
| } | ||
| return val, true |
Member
There was a problem hiding this comment.
Ignoring the empty arg should probably be done in NextN for more consistent behavior? It's a bit odd that one would skip over empty args and the other wouldn't
Member
There was a problem hiding this comment.
Would go a step further and do the same for RemoveN
| args := strings.Split(commandLine, " ") | ||
|
|
||
| var ( | ||
| name string |
Member
There was a problem hiding this comment.
Would be good to leave a comment here explaining this is to allow something like / command to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this change you can put as much spaces as you want into the command
something like this:
/tell "Cool guy" hello!will not result an error any more