Resolution for #1946 was incorrect. This commit finally solves it. #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Resolution for #1946 was incorrect. This commit should solve it for good.
The problem: When using a compound index where one of the properties is the primary key and the table uses auto-incremented primary keys, live queries on that compund index aren't properly notified when new items are added that affects the query.
The previous fix had the correct thought but a bug in the implementation. The unit tests happened to succeed despite of this (which was pure luck). It added primary key number instead of the array containing the primary key number and the other parts of the compound index.