fix timeout bug for etcd3 client connect #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byxorna
force-pushed
the
gabe/fix-etcd-timeout-bug
branch
from
b39d4a4
to
94bd948
Compare
|
Bump! Who should i @mention to get traction on getting this merged? Is there a CLA to sign? |
srenatus
approved these changes
Sep 10, 2018
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
fix timeout bug for etcd3 client connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya! Subtle bug here for
etcd3storage backend. The timeout was being unnecessarily multiplied bytime.Secondcausing a near-infinite timeout before returning on connection errors. This makes debugging Dex with etcd storage very annoying :)