Optionally return graph object from cello_probs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbernste
approved these changes
May 18, 2022
|
Thanks for merging @mbernste. What is the cello policy for new releases, so that this and the bugfix before come to life on pypi and can be easily managed in conda environments? |
|
Hi, there's no strict policy for new releases, it is mostly just me maintaining CellO. I have incorporated this bug fix into the latest release (v2.0.4), which has now been uploaded to PyPI. |
|
Great! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your great tool.
This PR adds the possibility to let
cello_probsoptionally return the graph object. The parameterreturn_graphis used for this. This is by defaultFalseand therefore does not change the original behavior. If it is set toTruethe graph is returned as the third object in addition tofigandax.The background is that I would like to save the graph object in a different format, as well as recolor it if necessary. Also it allows to output all terminal nodes easily, for example.