FEATURE: telemetry events from devtron #517
Conversation
vikramdevtron
changed the title
| return nil, err | ||
| } | ||
|
|
||
| _, err = cron.AddFunc(fmt.Sprintf("@every %dm", 1), watcher.HeartbeatEventForTelemetry) |
There was a problem hiding this comment.
if orchestrator bounces timer will get reset
There was a problem hiding this comment.
in that case we can get more than one event for heartbeat is this will create problem ?
|
|
||
| func (impl *TelemetryEventClientImpl) HeartbeatEventForTelemetry() { | ||
| impl.logger.Info(">>>>>>>>>>VIKI startup heartbeat event ") | ||
| clusterBean, err := impl.clusterService.FindOne(cluster.ClusterName) |
|
|
||
| func (impl AppListingRepositoryImpl) FindAppCount(isProd bool) (int, error) { | ||
| var count int | ||
| query := "SELECT count(distinct pipeline.app_id) from pipeline pipeline " + |
There was a problem hiding this comment.
can we use ORM query instead of native
vikramdevtron
changed the title
client/telemetry/PosthogClient.go
Outdated
| cfg := &PosthogConfig{} | ||
| err := env.Parse(cfg) | ||
| if err != nil { | ||
| logger.Error("err", err) |
There was a problem hiding this comment.
proper stack-trace will not be printed here
There was a problem hiding this comment.
logger.Errorw("exception caught while parsing posthog config", "err", err)
done
| ciPipelineRepository: ciPipelineRepository, pipelineRepository: pipelineRepository, | ||
| } | ||
| watcher.HeartbeatEventForTelemetry() | ||
| _, err := cron.AddFunc(fmt.Sprintf("@every %dm", 5), watcher.SummeryEventForTelemetry) |
There was a problem hiding this comment.
please make duration configurable
| return | ||
| } | ||
| cm, err := impl.K8sUtil.GetConfigMap(impl.aCDAuthConfig.ACDConfigMapNamespace, DevtronUniqueClientIdConfigMap, client) | ||
| if err != nil && strings.Contains(err.Error(), "not found") { |
There was a problem hiding this comment.
do we have some error codes available to identify not found?
we should be using that instead of not found string match
| return | ||
| } | ||
|
|
||
| client, err := impl.K8sUtil.GetClientForIncluster(cfg) |
| } | ||
| impl.PosthogClient.Client.Enqueue(posthog.Capture{ | ||
| DistinctId: ucid, | ||
| Event: fmt.Sprintf("heartbeat event sent from devtron"), |
There was a problem hiding this comment.
use short keywords as event name, filtering will be easier
| }) | ||
| } | ||
|
|
||
| type CronLoggerImpl struct { |
There was a problem hiding this comment.
why we are using derived logger class?
There was a problem hiding this comment.
not required here, removed
internal/util/K8sUtil.go
Outdated
| // creates the in-cluster config | ||
| config, err := rest.InClusterConfig() | ||
| if err != nil { | ||
| panic(err.Error()) |
There was a problem hiding this comment.
panic from code, is it intended ?
There was a problem hiding this comment.
error logged, returned error
Description
telemetry events such as Summary (app total count, user count total, env n cluster count total, ci and cd daily runs count, helm charts total count, s scan runs daily) or Heatbeat events sent to posthog.
Fixes # (issue): #407
Type of change
How Has This Been Tested?
Checklist: