Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Kubelink Requests getting Failed for gRPC method GetAppDetails #5012

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix: Kubelink Requests getting Failed for gRPC method GetAppDetails #5012

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8625ef
fixed
ShashwatDadhich Apr 25, 2024
223a525
code review comments
ShashwatDadhich Apr 25, 2024
ff0111a
Merge remote-tracking branch 'origin/main' into resource_tree_fix
ShashwatDadhich Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixed
  • Loading branch information
@ShashwatDadhich
ShashwatDadhich committed Apr 25, 2024
commit e8625efbf1b8a8174f67e39b2b9433ddb851f84b
4 changes: 4 additions & 0 deletions api/restHandler/app/appList/AppListingRestHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,10 @@ func (handler AppListingRestHandlerImpl) getAppDetails(ctx context.Context, appI
// TODO: move this to service
func (handler AppListingRestHandlerImpl) fetchResourceTree(w http.ResponseWriter, r *http.Request, appId int, envId int, acdToken string, cdPipeline *pipelineConfig.Pipeline) (map[string]interface{}, error) {
var resourceTree map[string]interface{}
if !cdPipeline.DeploymentAppCreated {
handler.logger.Infow("deployment for this pipeline does not exist")
ShashwatDadhich marked this conversation as resolved.
Show resolved Hide resolved
return resourceTree, nil
}
if len(cdPipeline.DeploymentAppName) > 0 && cdPipeline.EnvironmentId > 0 && util.IsAcdApp(cdPipeline.DeploymentAppType) {
// RBAC enforcer Ends
query := &application2.ResourcesQuery{
Expand Down
Loading