Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Image promotion policy #4762

Merged
merged 13 commits into from
May 20, 2024
Merged

doc: Image promotion policy #4762

merged 13 commits into from
May 20, 2024

Conversation

ashokdevtron
Copy link
Contributor

@ashokdevtron ashokdevtron commented Mar 7, 2024

  • Base ready
  • RBAC ready
  • Added latest snapshots
  • Included Artifact promoter role
  • Added CLI steps

Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments. We can go through these together once.

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron
Copy link
Contributor Author

ashokdevtron commented May 14, 2024

@abhibhaw, I have added the CLI steps. Please note the devtron-cli repo is a private one and is inaccessible to public. Let's connect once to discuss how to make the configuration steps (in this doc) useful to our audience.

Copy link

gitguardian bot commented May 20, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret 0d9f1d2 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 0d9f1d2 charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ashokdevtron ashokdevtron merged commit 279b671 into main May 20, 2024
6 checks passed
@ashokdevtron ashokdevtron deleted the image-promotion-policy branch May 20, 2024 10:26
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants