feat:validation for pipeline Type

api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go

@@ -431,7 +431,7 @@ func (handler PipelineConfigRestHandlerImpl) PatchCiPipelines(w http.ResponseWri
 	}
 	createResp, err := handler.pipelineBuilder.PatchCiPipeline(&patchRequest)
 	if err != nil {
-		if err.Error() == bean1.PIPELINE_NAME_ALREADY_EXISTS_ERROR {
+		if err.Error() == bean1.PIPELINE_NAME_ALREADY_EXISTS_ERROR || err.Error() == bean1.PIPELINE_TYPE_IS_NOT_VALID {
 			handler.Logger.Errorw("service err, pipeline name already exist ", "err", err)
 			common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
 			return

pkg/bean/app.go

@@ -181,6 +181,15 @@ type ExternalCiConfigRole struct {
 type PatchAction int
 type PipelineType string
 
+func (pType PipelineType) IsValidPipelineType() bool {
+	switch pType {
+	case NORMAL, LINKED, EXTERNAL, CI_JOB, LINKED_CD:
+		return true
+	default:
+		return false
+	}
+}
+
 const (
 	CREATE        PatchAction = iota
 	UPDATE_SOURCE             //update value of SourceTypeConfig

pkg/pipeline/CiCdPipelineOrchestrator.go

@@ -808,7 +808,10 @@ func (impl CiCdPipelineOrchestratorImpl) CreateCiConf(createRequest *bean.CiConf
 		}
 		// Rollback tx on error.
 		defer tx.Rollback()
-
+		if !ciPipeline.PipelineType.IsValidPipelineType() {
+			impl.logger.Debugw(" Invalid PipelineType", "ciPipeline.PipelineType", ciPipeline.PipelineType)
+			return nil, errors.New(bean2.PIPELINE_TYPE_IS_NOT_VALID)
+		}
 		ciPipelineObject := &pipelineConfig.CiPipeline{
 			AppId:                    createRequest.AppId,
 			IsManual:                 ciPipeline.IsManual,

pkg/pipeline/bean/CiBuildConfig.go

@@ -19,6 +19,7 @@ const Main = "main"
 const UniquePlaceHolderForAppName = "$etron"
 
 const PIPELINE_NAME_ALREADY_EXISTS_ERROR = "pipeline name already exist"
+const PIPELINE_TYPE_IS_NOT_VALID = "PipelineType is not valid"
 
 type CiBuildConfigBean struct {
 	Id                        int                `json:"id"`

scripts/sql/224_pipeline_type.down.sql

@@ -0,0 +1 @@
+---- Not Required

scripts/sql/224_pipeline_type.up.sql

@@ -0,0 +1 @@
+UPDATE   "public"."ci_pipeline"  SET ci_pipeline_type='LINKED' WHERE ci_pipeline_type='CI_EXTERNAL';