legacy code fix from loop in query to bulk query

pkg/auth/user/RoleGroupService.go

@@ -733,8 +733,12 @@ func (impl RoleGroupServiceImpl) DeleteRoleGroup(bean *bean.RoleGroup) (bool, er
 	if err != nil {
 		impl.logger.Errorw("error in getting all roles for groups", "err", err)
 	}
-	for _, roleGroupRoleMapping := range allRoleGroupRoleMappings {
-		err = impl.roleGroupRepository.DeleteRoleGroupRoleMappingByRoleId(roleGroupRoleMapping.RoleId, tx)
+	roleGroupRoleMappingIds := make([]int, 0, len(allRoleGroupRoleMappings))
+	for _, roleMapping := range allRoleGroupRoleMappings {
+		roleGroupRoleMappingIds = append(roleGroupRoleMappingIds, roleMapping.Id)
+	}
+	if len(roleGroupRoleMappingIds) > 0 {
+		err = impl.roleGroupRepository.DeleteRoleGroupRoleMappingByIds(roleGroupRoleMappingIds, tx)
 		if err != nil {
 			impl.logger.Errorw("error in deleting role group role mapping by role id", "err", err)
 			return false, err

pkg/auth/user/UserService.go

@@ -1261,10 +1261,14 @@ func (impl *UserServiceImpl) DeleteUser(bean *bean.UserInfo) (bool, error) {
 		impl.logger.Errorw("error while fetching user from db", "error", err)
 		return false, err
 	}
-	for _, item := range urm {
-		_, err = impl.userAuthRepository.DeleteUserRoleMapping(item, tx)
+	userRolesMappingIds := make([]int, 0, len(urm))
+	for _, urmModel := range urm {
+		userRolesMappingIds = append(userRolesMappingIds, urmModel.Id)
+	}
+	if len(userRolesMappingIds) > 0 {
+		err = impl.userAuthRepository.DeleteUserRoleMappingByIds(userRolesMappingIds, tx)
 		if err != nil {
-			impl.logger.Errorw("error while fetching user from db", "error", err)
+			impl.logger.Errorw("error in DeleteUser", "userRolesMappingIds", userRolesMappingIds, "err", err)
 			return false, err
 		}
 	}