-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag + Image Digest at CD #4507
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to include latest images having digest options as well. And maybe we can handle that too with this. Also we need to give some ideal pipelines (Devtron recommended) with this doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review comments
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Outdated
Show resolved
Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Outdated
Show resolved
Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the content is great, and we have covered all the topics in detail, one concern I have is repetition. A lot of same / similar content in repeated this will make it harder for us to manage and for users it may be confusing as while I was reading every time it was in my mind I think I read this few lines above.
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Outdated
Show resolved
Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Outdated
Show resolved
Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Show resolved
Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Changes have been incorporated
Completed: