-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Helm async deploy Devtron Apps #4045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-exp
commented
Oct 10, 2023
Ash-exp
commented
Oct 10, 2023
Ash-exp
commented
Oct 10, 2023
Ash-exp
commented
Oct 10, 2023
internal/sql/repository/pipelineConfig/CdWorfkflowRepository.go
Outdated
Show resolved
Hide resolved
vikramdevtron
previously approved these changes
Nov 21, 2023
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Nov 21, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
vikramdevtron
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in Devtron Apps with Helm installation, we are performing the Install/Upgrade in synchronous mode. With this flow, in some cases the API context expires as the Install/ Upgrade may take too long. The common cases for this behaviour are:
In this PR we are performing Helm install/ Upgrade for devtron Apps in asynchronous mode. This feature will flag based. Use
ENABLE_ASYNC_INSTALL_DEVTRON_CHART
(bool) in config map:devtron-cm
to enable/disable this feature. Default value is set tofalse
.Other Environment flags are: (config map:
devtron-cm
)gRPC Timeout For Devtron App Deployment:
DEVTRON_CHART_INSTALL_REQUEST_TIMEOUT
(in mins) default 6Nats Configuration:
CONSUMER_CONFIG_JSON
(json) Default natsMsgProcessingBatchSize is 1.Fixes #4264
How Has This Been Tested?
Test Cases:
Checklist:
Does this PR introduce a user-facing change?