fix: new api added for getting ciPipelineDetails by only ciPipelineId for CLI #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash100198
changed the title
Kripansh
reviewed
Aug 1, 2023
Kripansh
reviewed
Aug 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
prakash100198
requested review from
vikramdevtron and
nishant-d
as code owners
|
vikramdevtron
approved these changes
Feb 1, 2024
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Ash-exp
added a commit
that referenced
this pull request
Feb 5, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: sanity after ent sync * added: todo comment * fix: new api added for getting ciPipelineDetails by only ciPipelineId for CLI (#3708) * new api added for getting ciPipelineDetails by only ciPipelineId * appName field added in ci-pipeline struct * appType field added in ci-pipeline struct * code review comments incorporation --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Prakash <prakash.kumar@devtron.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New api added for fetching ciPipelineDetails by just ciPipelineId
Fixes #3578
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?