fix: allow config expressions in devspace-schema.json#2787
Merged
FabianKramm merged 1 commit intodevspace-sh:mainfrom Feb 2, 2024
Merged
fix: allow config expressions in devspace-schema.json#2787FabianKramm merged 1 commit intodevspace-sh:mainfrom
FabianKramm merged 1 commit intodevspace-sh:mainfrom
Conversation
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fixes devspace-sh#2770 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
FabianKramm
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2770
resolves ENG-2531
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace json schema incorrectly shows variables and expressions as invalid.
What else do we need to know?
May also need to add variable expressions, however these cannot be used for structural changes.