fix: remote cache key should consider helm release name #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschoenlaub
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
mschoenlaub
force-pushed
the
fix-cache-usage-for-helm
branch
from
16d4229 to
2fe8e56
Compare
lizardruss
approved these changes
Sep 13, 2023
Collaborator
lizardruss
left a comment
lizardruss
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve?
resolves #2525
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace would leave behind orphaned helm releases when setting a helm release name
What else do we need to know?
It doesn't fully fix the use case in #2525, as the originally expected behavior doesn't play well with
devspacecurrently.However, this fix makes
devspaceavoid "orphaned" deployments lingering around.IMO this is the behavior most people would expect, as the default is to purge all deployments associated with a project.