fix: prevent panic when checking server version without a kube contex… #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t configured Fixes devspace-sh#2711 Fixed ENG-2019 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
lizardruss
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
FabianKramm
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t configured
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve?
Resolves #2711
Fixed ENG-2019
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace panics when the kube context is unset
What else do we need to know?
Typically does not happen if
kubectl config current-contextreturns successfully. Runningminikube deletecan clear the current-context.