fix: allow SSH to be enabled and disabled via variable#2712
Merged
FabianKramm merged 1 commit intodevspace-sh:mainfrom Sep 18, 2023
Merged
fix: allow SSH to be enabled and disabled via variable#2712FabianKramm merged 1 commit intodevspace-sh:mainfrom
FabianKramm merged 1 commit intodevspace-sh:mainfrom
Conversation
lizardruss
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
lizardruss
force-pushed
the
ENG-1886
branch
22 times, most recently
from
e78e743 to
a8ff9b4
Compare
Fixes devspace-sh#2693 Fixes ENG-1886 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
lizardruss
force-pushed
the
ENG-1886
branch
from
a8ff9b4 to
20bb340
Compare
Collaborator
Author
|
@FabianKramm This is ready for review, but the e2e tests are really flakey. The issue seems to be that the helm deploy fails intermittently, sometimes (but not always) accompanied by a |
FabianKramm
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Fixes #2693
Fixes ENG-1886
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace did not allow explicitly disabling SSH when other SSH was given.
What else do we need to know?
This also enables disabling SSH via variables.