fix: add localRegistry to imported sections#2666
Merged
FabianKramm merged 1 commit intodevspace-sh:mainfrom Jul 7, 2023
Merged
fix: add localRegistry to imported sections#2666FabianKramm merged 1 commit intodevspace-sh:mainfrom
FabianKramm merged 1 commit intodevspace-sh:mainfrom
Conversation
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Fixes devspace-sh#2665 Fixes ENG-1686 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
lizardruss
force-pushed
the
local-registry-imports
branch
from
a957ee7 to
72d01e0
Compare
FabianKramm
approved these changes
Jul 7, 2023
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@lizardruss thanks a lot for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2665
Fixes ENG-1686
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace did not import localRegistry configuration
What else do we need to know?
Added a section to the docs to describe import sections that are importable.