chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml#2663
Merged
lizardruss merged 1 commit intodevspace-sh:mainfrom Aug 17, 2023
Juneezee:chore/yaml
Merged
chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml#2663lizardruss merged 1 commit intodevspace-sh:mainfrom Juneezee:chore/yaml
github.com/ghodss/yaml with sigs.k8s.io/yaml#2663lizardruss merged 1 commit intodevspace-sh:mainfrom
Juneezee:chore/yaml
Conversation
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Contributor
Author
|
Hello @FabianKramm @LukasGentele . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago. I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them. Thank you for your time and consideration. I truly appreciate it. ❤️ |
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
lizardruss
approved these changes
Aug 16, 2023
Collaborator
lizardruss
left a comment
lizardruss
left a comment
There was a problem hiding this comment.
Thanks so much for the PR!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
The
github.com/ghodss/yamlpackage is no longer actively maintained. There are numerous inquiries about the project's status on its issue tracker: https://github.com/ghodss/yaml/issues.sigs.k8s.io/yamlis a permanent fork ofgithub.com/ghodss/yaml, which is actively maintained by Kubernetes SIG and widely used in K8s projects.Please provide a short message that should be published in the DevSpace release notes
Replace unmaintained
github.com/ghodss/yamldependency withsigs.k8s.io/yaml.What else do we need to know?