fix: add option to disable colors for users with conflicting backgrou…#2653
Merged
FabianKramm merged 1 commit intodevspace-sh:mainfrom Jun 22, 2023
Merged
fix: add option to disable colors for users with conflicting backgrou…#2653FabianKramm merged 1 commit intodevspace-sh:mainfrom
FabianKramm merged 1 commit intodevspace-sh:mainfrom
Conversation
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
…nd colors. Fixes devspace-sh#2651 Fixes ENG-1494 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
lizardruss
force-pushed
the
disable-colors
branch
from
7a41e21 to
6989429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd colors.
Fixes #2651
Fixes ENG-1494
What issue type does this pull request address?
/kind bugfix
/kind enhancement
What does this pull request do? Which issues does it resolve?
resolves #2651
Please provide a short message that should be published in the DevSpace release notes
Add an option to disable log output colors to support different backgrounds.
What else do we need to know?
This was the simplest option, but open to other ideas. Ideally we would support a light mode and dark mode theme, but that will require more effort.