Skip to content

Added proper regex and validation message for container registry chec… #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabianKramm merged 1 commit into from
Apr 28, 2023
Merged

Added proper regex and validation message for container registry chec… #2633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/devspace/configure/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ func (m *manager) AddImage(imageName, image, projectNamespace, dockerfile string
registryHostname, err = m.log.Question(&survey.QuestionOptions{
Question: "Please provide the registry hostname without the image path (e.g. gcr.io, ghcr.io, ecr.io)",
DefaultValue: "gcr.io",
ValidationRegexPattern: "^[^A-Z\\s]+\\.[^A-Z\\s]+$",
ValidationMessage: "Error parsing registry username: must only include lowercase letters.",
ValidationRegexPattern: "^(?!-)[a-z0-9-]{1,63}(\\.[a-z0-9-]{1,63})*$",
ValidationMessage: "Error parsing registry hostname: must only include letters, digits, dots and hyphens and cannot exceed 253 characters.",
})
if err != nil {
return err
Expand Down