updateImageTags actually defaults to true#2582
updateImageTags actually defaults to true#2582opticoder wants to merge 1 commit intodevspace-sh:mainfrom
Conversation
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@opticoder thanks for the PR! It actually defaults to |
|
@FabianKramm Thanks for the quick reply! But doesn't it mean then here https://www.devspace.sh/docs/configuration/deployments/#deployments-updateImageTags default value is not correct? And if yes, should I change the PR or create a new one? |
|
@opticoder oh yes! You are correct its actually wrong in the other place! Yes you can change this PR or create another one, both is fine! Thank you! |
|
updated the fix for default to true |
|
Closing in favor of #2714, since there were fixes to the documentation generation code needed to avoid overwriting this change. |
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind documentation
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)fix wrong updateImageTags default value mention in docs
Please provide a short message that should be published in the DevSpace release notes
fix updateImageTags default value mention in docs
What else do we need to know?