Skip to content

updateImageTags actually defaults to true#2582

Closed
opticoder wants to merge 1 commit intodevspace-sh:mainfrom
opticoder:patch-1
Closed

updateImageTags actually defaults to true#2582
opticoder wants to merge 1 commit intodevspace-sh:mainfrom
opticoder:patch-1

Conversation

@opticoder
Copy link

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind documentation

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
fix wrong updateImageTags default value mention in docs

Please provide a short message that should be published in the DevSpace release notes
fix updateImageTags default value mention in docs

What else do we need to know?

@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a6c40c
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/6435f135cbcaa80008d22977
😎 Deploy Preview https://deploy-preview-2582--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FabianKramm
Copy link
Collaborator

@opticoder thanks for the PR! It actually defaults to true, so in the docs its actually correct

@opticoder
Copy link
Author

@FabianKramm Thanks for the quick reply! But doesn't it mean then here https://www.devspace.sh/docs/configuration/deployments/#deployments-updateImageTags default value is not correct? And if yes, should I change the PR or create a new one?

@FabianKramm
Copy link
Collaborator

FabianKramm commented Mar 6, 2023

@opticoder oh yes! You are correct its actually wrong in the other place! Yes you can change this PR or create another one, both is fine! Thank you!

@opticoder opticoder closed this Apr 11, 2023
@opticoder opticoder deleted the patch-1 branch April 11, 2023 22:51
@opticoder opticoder changed the title updateImageTags actually defaults to false updateImageTags actually defaults to true Apr 11, 2023
@opticoder opticoder restored the patch-1 branch April 11, 2023 23:22
@opticoder opticoder reopened this Apr 11, 2023
@opticoder
Copy link
Author

updated the fix for default to true

@lizardruss
Copy link
Collaborator

Closing in favor of #2714, since there were fixes to the documentation generation code needed to avoid overwriting this change.

@lizardruss lizardruss closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants