fix: port forward to local registry with multiple dependencies#2425
Merged
FabianKramm merged 2 commits intodevspace-sh:mainfrom Nov 17, 2022
Merged
fix: port forward to local registry with multiple dependencies#2425FabianKramm merged 2 commits intodevspace-sh:mainfrom
FabianKramm merged 2 commits intodevspace-sh:mainfrom
Conversation
lizardruss
force-pushed
the
local-registry-dependencies
branch
from
581e2fb to
790e265
Compare
lizardruss
changed the title
lizardruss
requested review from
FabianKramm and
LukasGentele
as code owners
Contributor
|
just tested w/ the same process that created this issue for us in the first place and it is now working as desired! 🔥 |
FabianKramm
approved these changes
Nov 17, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@lizardruss thanks a lot for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve?
resolves #2411
Fixes ENG-603
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace could not reuse a local registry if required by multiple dependencies
What else do we need to know?
This is a basic fix, where the registry is matched by name. If dependencies use different registry configurations, then the last one wins.