fix: skip /auth call for ACR registries#2376
Merged
FabianKramm merged 1 commit intodevspace-sh:mainfrom Oct 19, 2022
Merged
Conversation
FabianKramm
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2365
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace always attempts a registry authentication call. Azure Container registries use a different authentication method, and no longer responds correctly to
/authrequests. They encourage users to useaz acr loginto refresh their credentials instead.What else do we need to know?
DevSpace will log a message reminding users that they can refresh their credentials with
az acr login